Re: softlockups in multi_cpu_stop

[Linus Torvalds]

On Fri, Mar 6, 2015 at 1:12 PM, Jason Low <jason.low2@xxxxxx> wrote:
>
> +       while (true) {
> +               if (sem->owner != owner)
> +                       break;

That looks *really* odd.

Why is this not

        while (sem->owner == owner) {

Also, this "barrier()" now lost the comment:

> +               barrier();

so it looks very odd indeed.

                     Linus
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/