Re: [PATCH 10/12] clocksource: Mostly kill clocksource_register()

From: Ingo Molnar
Date: Sat Mar 07 2015 - 04:45:23 EST



* John Stultz <john.stultz@xxxxxxxxxx> wrote:

> A long running project has been to cleanup remaining uses
> of clocksource_register(), replacing it with the simpler
> clocksource_register_khz/hz().

s/.$/ functions.

> However, there are a few cases where we need to self-define
> our mult/shift values, so switch the function to a more
> obviously internal __clocksource_register(), and consolidate

s/(),/() name,

> much of the internal logic so we don't have duplication.

> + if (freq) {
> + /*
> + * Calc the maximum number of seconds which we can run before
> + * wrapping around. For clocksources which have a mask > 32bit
> + * we need to limit the max sleep time to have a good
> + * conversion precision. 10 minutes is still a reasonable
> + * amount. That results in a shift value of 24 for a
> + * clocksource with mask >= 40bit and f >= 4GHz. That maps to
> + * ~ 0.06ppm granularity for NTP.

s/32bit/32-bit
s/40bit/40-bit

Thanks,

Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/