Re: [PATCH] regmap: introduce regmap_name to fix syscon regmap trace events
From: Mark Brown
Date: Sat Mar 07 2015 - 05:58:07 EST
On Fri, Mar 06, 2015 at 03:16:55PM +0100, Philipp Zabel wrote:
> #include <linux/sort.h>
> -#include <trace/events/regmap.h>
>
> #include "internal.h"
>
> +#include <trace/events/regmap.h>
> +
The change is basically OK but the above is a bit too funky for my
taste - it feels like it's asking for annoying compile breakage if
anyone changes anything. I'd be more inclined to move the header
somewhere where the events stuff can see it than do this.
Attachment:
signature.asc
Description: Digital signature