Re: [PATCH RESEND] Staging: rtl8188eu: fix double unlock
From: Larry Finger
Date: Sat Mar 07 2015 - 12:44:31 EST
On 03/07/2015 11:35 AM, Matteo Semenzato wrote:
Il giorno sab, 07/03/2015 alle 11.28 -0600, Larry Finger ha scritto:
Have you actually tested this patch, or did you find this with some static checker?
Larry
The double unlock was found using smatch.
Are you really willing to test changes in locking based on a static checker? I
would not be so quick.
By the way, my reading of the documentation is that up releases the lock whereas
down sets it. Thus, I think your patch introduces a bug rather than fix one. I
agree that there is a mismatch, but I do not think your patch fixes anything.
Until this is actually tested on running code, NACK.
Larry
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/