Re: [PATCH 1/1] perf annotate: Fix fallback to unparsed disassembler line

[Ingo Molnar]

* Arnaldo Carvalho de Melo <acme@xxxxxxxxxx> wrote:

> [...]
> 
> Further investigation is needed to figure out the nature of the 
> objdump output change so as to make the parser grok it.

Btw., maybe someone finds this interesting: we could also (re-)use the 
in-kernel disassembler (on x86 and any other architecture that might 
have one), which used by live patching facilities (kprobes et al).

See arch/x86/lib/insn.c.

The 'visualization' bit is missing entirely: but it does a lot of the 
hard work of knowing about the instruction format: it knows about 
essentially all x86 instructions and is able to determine instruction 
boundaries, and can decode immediate constants.

Using this in tools/perf/ would have the added advantage that we could 
then use the dissasembly in kernel oops output (nice feature!) - plus 
tooling folks would help us fix and extend the kernel's disassembler! 
;-)

Thanks,

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/