Re: [PATCH_V2] ASoC: jz4740: Add jz4780 support

[Lars-Peter Clausen]

On 03/09/2015 12:23 PM, Zubair Lutfullah Kakakhel wrote:
[...]
> @@ -460,6 +499,9 @@ static int jz4740_i2s_dev_probe(struct platform_device *pdev)
>
>   	platform_set_drvdata(pdev, i2s);
>
> +	if (i2s->version >= JZ_I2S_JZ4780)
> +		jz4740_i2s_dai.symmetric_rates = 0;

We shouldn't modify driver global structs from a device instance. Just add a 
second copy of jz4740_i2s_dai for the jz4780 without the bit set.

- Lars

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/