Re: [RFC PATCH] spi: Ensure that CS line is in non-active state after setup

[Andy Shevchenko]

On Mon, Mar 9, 2015 at 9:11 AM, Ivan T. Ivanov <iivanov@xxxxxxxxxx> wrote:
>
> On Sun, 2015-03-08 at 20:01 +0000, Mark Brown wrote:
>> On Fri, Mar 06, 2015 at 05:45:15PM +0200, Ivan T. Ivanov wrote:
>>
>> >         if (spi->master->setup)
>> >                 status = spi->master->setup(spi);
>> > +       else
>> > +               spi_set_cs(spi, false);
>>
>> Why would this be conditional on there not being a setup operation?
>> It's a good idea, I just don't see why the backstop isn't always useful.
>
> I was thinking that this is expected to be handled inside
> setup operation, nothing more.

Agree with Mark. It's perhaps a good idea to call unconditionally
before ->setup().


-- 
With Best Regards,
Andy Shevchenko
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/