Re: [PATCH 1/2] x86: save r11 into pt_regs->flags on SYSCALL64 fastpath

From: Ingo Molnar
Date: Mon Mar 09 2015 - 12:02:42 EST



* Denys Vlasenko <dvlasenk@xxxxxxxxxx> wrote:

> Before this patch, r11 was saved in pt_regs->r11.
> Which looks natural, but requires messy shuffling to/from iret frame
> whenever ptrace or e.g. iopl wants to modify flags - because
> that's how this register is used by SYSCALL/SYSRET.
>
> This patch saves r11 in pt_regs->flags,
> and uses that value for SYSRET64 insn. Shuffling is eliminated.
>
> stub_iopl is no longer needed: pt_regs->flags needs no fixing up.

Could you please split this into two patches: R11 saving, and
stub_iopl removal?

For x86/asm changes we want as small changes as physically possible.

Thanks,

Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/