Re: [PATCH v5 3/8] pinctrl: cygnus: add initial IOMUX driver support
From: Linus Walleij
Date: Mon Mar 09 2015 - 12:28:36 EST
On Thu, Mar 5, 2015 at 9:03 AM, Paul Bolle <pebolle@xxxxxxxxxx> wrote:
>>[...]
>> +MODULE_AUTHOR("Ray Jui <rjui@xxxxxxxxxxxx>");
>> +MODULE_DESCRIPTION("Broadcom Cygnus IOMUX driver");
>> +MODULE_LICENSE("GPL v2");
>
> These three macros will be preprocessed away. (And I guess you could
> also drop the linux/module.h include, but I haven't actually tested that
> guess.)
I think you're right. Or I fear you're right.
But this problem is present in so many drivers that a generic
fixup needs to be done with a script and across an entire subsystem
at once, and besides I'm not sure of these macros disturb so much.
They are documentation in a sense, albeit a kind of documentation
we used before we had git to record the actual authors of the
code.
Yours,
Linus Walleij
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/