Re: [PATCH 3/4] Added input buffer from the terminal.

From: Mark Brown
Date: Mon Mar 09 2015 - 14:38:42 EST


On Sat, Mar 07, 2015 at 12:56:34PM -0500, Adrian Remonda wrote:

> + int ret = 0;
> + char *pSrc = src;

The kernel coding style doesn't use Hungarian notation...

> + if (input_tx) {
> + size = strlen(input_tx+1);
> + tx = (uint8_t *)malloc(size);
> + rx = (uint8_t *)malloc(size);

You should never need to cast the return value of malloc() - if it's
needed it's masking some other problem.

Attachment: signature.asc
Description: Digital signature