Re: [PATCH 1/4] Cleaned hexadecimal dump

From: Mark Brown
Date: Mon Mar 09 2015 - 14:40:53 EST


On Sat, Mar 07, 2015 at 12:56:32PM -0500, Adrian Remonda wrote:

> +static void hexDump(const void *src, size_t length, size_t bLine, char *prefix)
> +{

Please call this hex_dump or something - that's more in line with the
kernel coding style. Please also don't vUse aHungarian nNotation, it's
also not the kernel coding style.

Attachment: signature.asc
Description: Digital signature