Re: [PATCH 1/2] tracing: remove ftrace:function TRACE_EVENT_FL_USE_CALL_FILTER flag

[He Kuang]

ping..
On 2015/3/3 15:21, He Kuang wrote:
> TRACE_EVENT_FL_USE_CALL_FILTER flag in ftrace:functon event can be
> removed. This flag was first introduced in commit
> f306cc82a93d ("tracing: Update event filters for multibuffer").
>
> Now, the only place uses this flag is ftrace:function, but the filter of
> ftrace:function has a different code path with events/syscalls and
> events/tracepoints. It uses ftrace_filter_write() and perf's
> ftrace_profile_set_filter() to set the filter, the functionality of file
> 'tracing/events/ftrace/function/filter' is bypassed in function
> init_pred(), in which case, neither call->filter nor file->filter is
> used.
>
> So we can safely remove TRACE_EVENT_FL_USE_CALL_FILTER flag from
> ftrace:function events.
>
> Signed-off-by: He Kuang <hekuang@xxxxxxxxxx>
> ---
>   kernel/trace/trace_export.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/kernel/trace/trace_export.c b/kernel/trace/trace_export.c
> index 12e2b99..174a6a7 100644
> --- a/kernel/trace/trace_export.c
> +++ b/kernel/trace/trace_export.c
> @@ -177,7 +177,7 @@ struct ftrace_event_call __used event_##call = {			\
>   	},								\
>   	.event.type		= etype,				\
>   	.print_fmt		= print,				\
> -	.flags			= TRACE_EVENT_FL_IGNORE_ENABLE | TRACE_EVENT_FL_USE_CALL_FILTER, \
> +	.flags			= TRACE_EVENT_FL_IGNORE_ENABLE,		\
>   };									\
>   struct ftrace_event_call __used						\
>   __attribute__((section("_ftrace_events"))) *__event_##call = &event_##call;


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/