Re: [PATCH] pinctrl: at91: move lock/unlock_as_irq calls into request/release resources methods

From: Nicolas Ferre
Date: Tue Mar 10 2015 - 04:34:45 EST


Le 09/03/2015 17:14, Linus Walleij a Ãcrit :
> On Sun, Feb 8, 2015 at 7:23 PM, Boris Brezillon
> <boris.brezillon@xxxxxxxxxxxxxxxxxx> wrote:
>
>> The gpiochip_lock_as_irq call can fail and return an error, while the
>> irq_startup is not expected to fail (returns an unsigned int which is not
>> checked by irq core code).
>>
>> irq_request/release_resources functions have been created to address this
>> problem.
>>
>> Move gpiochip_lock/unlock_as_irq calls into
>> irq_request/release_resources functions to prevent using a gpio as an irq
>> if the gpiochip_lock_as_irq call failed.
>>
>> Signed-off-by: Boris Brezillon <boris.brezillon@xxxxxxxxxxxxxxxxxx>
>
> Patch applied with all the ACKs.

Hi Linus,

As suggested earlier, do you think it can be scheduled for the 4.0-rc
phase as a "fix"?

Bye,



> Happy new year J-C!
>
> Yours,
> Linus Walleij
>
>


--
Nicolas Ferre
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/