Re: [PATCH v7 3/5] power: max77843_battery: Add Max77843 fuel gauge device driver

[Beomho Seo]

On 03/09/2015 07:01 PM, Krzysztof Kozlowski wrote:
> 2015-03-09 1:36 GMT+01:00 Beomho Seo <beomho.seo@xxxxxxxxxxx>:
>> On 03/08/2015 05:14 AM, Sebastian Reichel wrote:
>>> Hi,
>>>
>>> On Mon, Mar 02, 2015 at 07:10:36PM +0900, Jaewon Kim wrote:
>>>> From: Beomho Seo <beomho.seo@xxxxxxxxxxx>
>>>>
>>>> This patch adds device driver of max77843 fuel gauge.
>>>> The driver support for battery fuel gauge in Maxim Max77843.
>>>> It is fuel-gauge systems for lithuum-ion batteries in handled and
>>>> portable devices.
>>>>
>>>> Cc: Sebastian Reichel <sre@xxxxxxxxxx>
>>>> Signed-off-by: Beomho Seo <beomho.seo@xxxxxxxxxxx>
>>>
>>> Reviewed-By: Sebastian Reichel <sre@xxxxxxxxxx>
>>>
>>> I can't take it as is, since it depends on the private header file
>>> of PATCH 1.
>>>
>>> -- Sebastian
>>>
>>
>> This patch reviewed by Sebastian.
>> Could you Please merge that your git tree ?
> 
> Hi,
> 
> Sorry for late response, but I finally got some time to look at this.
> This driver looks very similar to max17042_battery.c fuel gauge
> driver. Obtaining some properties looks exactly the same. The
> difference seems to be in new properties. The I2C address is the same.
> 
> I highly recommend to extend the max17042 driver instead. It already
> supports also max17047, max17050 and max77693.
> 
> Best regards,
> Krzysztof
> --
> To unsubscribe from this list: send the line "unsubscribe linux-pm" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> 

OK. I will follow your opinion about fuel gauge. I will extend the max17042 driver.
After test on my board, I will send a new patch set.

Best regards,
Beomho Seo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/