Re: [PATCH 1/4] perf, tools: Output running time and run/enabled ratio in CSV mode

From: Andi Kleen
Date: Tue Mar 10 2015 - 11:37:16 EST


> Why not handle both cases here?
>
> static void print_running(u64 run, u64 ena)
> {
> if (csv_output)
> fprintf(output, ...);
> else if (run != ena)
> fprintf(output, ...);
> }

print_running has 6 callers. run != ena is only needed
for two of them. So I don't think it makes sense to do.

-Andi
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/