Re: [PATCH 2/2] spi: qup: Request CS GPIO's during probe

[Mark Brown]

On Tue, Mar 10, 2015 at 02:53:17PM +0200, Ivan T. Ivanov wrote:
> 
> On Tue, 2015-03-10 at 11:06 +0000, Mark Brown wrote:

> > I'm sorry but I can't parse the above.  What does "they could issue
> > setup method" mean and why is it a problem?

> Client drivers could execute spi_setup() in probe(), so we have
> to ensure that CS GPIO's are available before this, no?

I see.  Yes, that's a concern.  It should be in the changelog.

> > > Requesting GPIO's in core framework is also not a easy
> > > option because of arguments here[1].

> > We should really fix that though.

> I think that pinctrl framework should automatically
> request pins belonging to group when state is selected.

That doesn't help users as not every GPIO is associated with a pin
controller - they'd still have to handle the case where they had to do
things themselves.

Attachment: signature.asc
Description: Digital signature