Re: gadgetfs broken since 7f7f25e8
From: Felipe Balbi
Date: Tue Mar 10 2015 - 17:08:46 EST
On Sun, Mar 08, 2015 at 02:35:25PM -0400, Alan Stern wrote:
> On Sun, 8 Mar 2015, Al Viro wrote:
>
> > On Sat, Mar 07, 2015 at 04:08:49PM -0500, Alan Stern wrote:
> > > On Sat, 7 Mar 2015, Alexander Holler wrote:
> > >
> > > > Am 07.03.2015 um 12:23 schrieb Alexander Holler:
> > > > > Am 04.03.2015 um 16:31 schrieb Alan Stern:
> > > > >
> > > > >> check to see what those values actually were. It's easy enough to fix
> > > > >> up, though; revised patch below.
> > > > >
> > > > > Thanks, in contrast to the patch from Al Viro that one applies.
> > > >
> > > > And as I've just tested it, it isn't complete. ep_config_operations will
> > > > be switched to ep_io_operations and suffers under the same problem of
> > > > not having initially (aio_)read/(aio_)write since commit 7f7f25e8 (3.16).
> > >
> > > Of course. I stated in the email accompanying the original version of
> > > this patch that it contained some corrections that Al's patch left out.
> > > You have to use the two of them together to fix all the issues.
> >
> > FWIW, I've pushed those two fixes in vfs.git#gadget; could I have your
> > s-o-b on the ep0 part? See 2b13438 in vfs.git...
>
> Certainly.
>
> Signed-off-by: Alan Stern <stern@xxxxxxxxxxxxxxxxxxx>
Just to make sure people know I'm okay with you taking the patch:
Acked-by: Felipe Balbi <balbi@xxxxxx>
--
balbi
Attachment:
signature.asc
Description: Digital signature