Re: [PATCH 02/45] scripts/headers.sh: add verbose option to make calls if defined

[Mikko Rapeli]

On Tue, Feb 17, 2015 at 04:18:59PM +0900, Masahiro Yamada wrote:
> 
> On Tue, 17 Feb 2015 00:05:05 +0100
> Mikko Rapeli <mikko.rapeli@xxxxxx> wrote:
> 
> > Useful when debugging the scripts.
> > 
> > Signed-off-by: Mikko Rapeli <mikko.rapeli@xxxxxx>
> > ---
> >  scripts/headers.sh | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/scripts/headers.sh b/scripts/headers.sh
> > index 95ece06..aa62fd8 100755
> > --- a/scripts/headers.sh
> > +++ b/scripts/headers.sh
> > @@ -7,7 +7,7 @@ set -e
> >  do_command()
> >  {
> >  	if [ -f ${srctree}/arch/$2/include/asm/Kbuild ]; then
> > -		make ARCH=$2 KBUILD_HEADERS=$1 headers_$1
> > +		make V=$KBUILD_VERBOSE ARCH=$2 KBUILD_HEADERS=$1 headers_$1
> >  	else
> >  		printf "Ignoring arch: %s\n" ${arch}
> >  	fi
> > -- 
> 
> 
> KBUILD_VERBOSE is already exported.
> 
> Why do you need to set V=... again here?

You're right, I'll drop this too. Thanks for the review!

-Mikko
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/