Re: [PATCH 2/3] dgnc: remove DGNC_VERIFY_BOARD macro

[Dan Carpenter]

On Tue, Mar 10, 2015 at 09:29:19PM +0200, Giedrius StatkeviÄius wrote:
>  static ssize_t dgnc_vpd_show(struct device *p, struct device_attribute *attr, char *buf)
>  {
> -	struct dgnc_board *bd;
> -	int count = 0;
> -	int i = 0;
> -
> -	DGNC_VERIFY_BOARD(p, bd);
> +	int count = 0, i = 0;

Don't redo the patch, but really these should be on separate lines.
This is an unwritten rule.  :)  Also there is no need to set "i".

regards,
dan carpenter
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/