Re: [PATCH] crypto: AES-NI: fix memory usage in GCM decryption

[Herbert Xu]

On Wed, Mar 11, 2015 at 09:01:02AM +0100, Stephan Mueller wrote:
>
> However, I think there is an error in the calculation of the AAD pointer 
> offset. That offset is currently calculated as:
> 
> assoc = (src + req->cryptlen + auth_tag_len);
> 
> But instead, it should be:
> 
> assoc = (src + req->cryptlen);
> 
> as our buffer is only cryptlen + assolen in size.
> 
> If you concur, I will write a patch and test it.

Yes that's the problem I was referring to.

Thanks,
-- 
Email: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/