Re: [PATCH RFC] leds: Add status code trigger

[Raphaël Teysseyre]

Le mardi 10 mars 2015 Ã 20:22 +0100, Pavel Machek a Ãcrit :
> Hi!
> 
> > This patch is very similar to mine patten trigger and all features are covered by my patch.
> > If you are considering to take this feature, could you consider my patch instead?
> > http://thread.gmane.org/gmane.linux.documentation/19116/focus=19135
> 
> That one is indeed better than this patch (as it supports almost
> arbitrary blinking pattern on single LED, it will not help much with
> smooth brightness control.

I agree, that patch supports more features than mine, I didn't find it
while browsing the mailing list archive.

> 
> Would solution below work for you?
> 
> Best regards,
> 									Pavel
> 
> > > I think I have interface to handle most of the issues: array of
> > > integers in "brightness, length in miliseconds".
> > > 
> > > So for example slowly blinking LED would be "0 1000msec, 255 1000
> > > msec". On off pattern would be "0 1000msec, 255 0msec, 255 1000msec, 0
> > > 0msec".
> > > 
> > > Rapahael, this should be able to do all the stuff you want to do. It
> > > can also do morse code, slow blinks, and combination of both. Do you
> > > want to try implementing it?
> >  		 	   		  
> 

I could implement it. This is how I'd do it :
When activated, the trigger would export three
sysfs attributes : pattern, pattern_repeat, and pattern_once.

	pattern : list of brightness/time couple, separated by newlines
		For the slowly blinking LED of your example,
		this attribute would contain :
		0 1000
		255 1000

		For a heartbeat-like pattern :
		0 1000
		255 100
		0 100
		255 100

	pattern_repeat : repeat this pattern indefinitely ?
		1 -> yes, 0 -> no

	pattern_once : if pattern_repeat = 0, writing 1 to this
		file makes the pattern run once .

Does that seem OK to you?

Regards,
RaphaÃl



--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/