Re: [PATCH 2/6] Drivers: hv: hv_balloon: keep locks balanced on add_memory() failure

From: Olaf Hering
Date: Thu Mar 12 2015 - 06:45:50 EST


On Wed, Mar 11, K. Y. Srinivasan wrote:

> +++ b/drivers/hv/hv_balloon.c
> @@ -652,6 +652,7 @@ static void hv_mem_hot_add(unsigned long start, unsigned long size,
> }
> has->ha_end_pfn -= HA_CHUNK;
> has->covered_end_pfn -= processed_pfn;
> + mutex_lock(&dm_device.ha_region_mutex);
> break;
> }

Should it call the wrapper instead of doing mutex_lock directly?
Like 'acquire_region_mutex(false);'.

Olaf
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/