Re: [PATCH 3/3] mtrr, mm, x86: Enhance MTRR checks for KVA huge page mapping

[Toshi Kani]

On Thu, 2015-03-12 at 11:03 +0000, Ingo Molnar wrote:
> * Toshi Kani <toshi.kani@xxxxxx> wrote:
> 
> > > Did it perhaps want to be the other way around:
> > > 
> > >         if (mtrr_state.have_fixed && (start < 0x1000000)) {
> > > 	...
> > >                 } else if (start < 0x100000) {
> > > 	...
> > > 
> > > or did it simply mess up the condition?
> > 
> > I think it was just paranoid to test the same condition twice...
> 
> Read the code again, it's _not_ the same condition ...

Oh, I see...  It must be a typo.  The fixed range is 0x0 to 0xFFFFF, so
it only makes sense to check with (start < 0x100000).

Thanks,
-Toshi

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/