Re: [PATCH] kernel:Change the function definiton of do_exit to comply with its function prototypes in kernel.h

From: Andrew Morton
Date: Thu Mar 12 2015 - 19:16:43 EST


On Wed, 11 Mar 2015 00:36:50 -0400 Nicholas Krause <xerofoify@xxxxxxxxx> wrote:

> This fixes the function definiton of do_exit to comply with its
> function prototype as defined in kernel.h as found when running
> sparse on the latest updated version of the mainline kernel.
>
> ...
>
> -void do_exit(long code)
> +void do_exit(long error_code)

We still have

include/linux/module.h:#define module_put_and_exit(code) do_exit(code)

Probably changing the header files is the way to go - error_code is a
bit of a mouthful.

Actually, using "exit_code" everywhere would be best - that's what the
thing does, and it gets copied into task_struct.exit_code.

And change complete_and_exit(code).

do_group_exit() already uses exit_code.

sys_exit_group() uses "error_code".

It's rather a little mess we've made in there!
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/