Re: [PATCH v3 1/6] staging: rtl8192e: fix coding style issues (merge broken strings)

[Joe Perches]

On Fri, 2015-03-13 at 00:53 +0100, Mateusz Kulikowski wrote:
[]
> diff --git a/drivers/staging/rtl8192e/rtl8192e/r8190P_rtl8256.c b/drivers/staging/rtl8192e/rtl8192e/r8190P_rtl8256.c
> index 0e6bdd2..01d2201 100644
> --- a/drivers/staging/rtl8192e/rtl8192e/r8190P_rtl8256.c
> +++ b/drivers/staging/rtl8192e/rtl8192e/r8190P_rtl8256.c
> @@ -47,8 +47,8 @@ void PHY_SetRF8256Bandwidth(struct net_device *dev,
>  						0x0e, bMask12Bits, 0x021);
>  
>  			} else {
> -				RT_TRACE(COMP_ERR, "PHY_SetRF8256Bandwidth(): "
> -					 "unknown hardware version\n");
> +				RT_TRACE(COMP_ERR,
> +					 "PHY_SetRF8256Bandwidth(): unknown hardware version\n");

Another thing you might consider is to change these
embedded function names in another patch to use
	"%s: ", __func__

				RT_TRACE(COMP_ERR,
					 "%s: "unknown hardware version\n",
					 __func__)

There's a cocci script for that.
http://cocci.systeme.lip6.narkive.com/nKXf6Bmy/finding-embedded-function-names



--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/