Re: [PATCH] selftests/exec: take into account that zero is a success code

[Shuah Khan]

On 03/13/2015 09:57 AM, Andrey Vagin wrote:
> Cc: Shuah Khan <shuahkh@xxxxxxxxxxxxxxx>
> Signed-off-by: Andrey Vagin <avagin@xxxxxxxxxx>

Andrey,

Please add a meaningful commit log for this patch and resend.

-- Shuah
> ---
>  tools/testing/selftests/exec/execveat.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tools/testing/selftests/exec/execveat.c b/tools/testing/selftests/exec/execveat.c
> index e238c95..6747a3f 100644
> --- a/tools/testing/selftests/exec/execveat.c
> +++ b/tools/testing/selftests/exec/execveat.c
> @@ -47,7 +47,7 @@ static int _check_execveat_fail(int fd, const char *path, int flags,
>  		fd, path?:"(null)", flags, errno_str);
>  	rc = execveat_(fd, path, argv, envp, flags);
>  
> -	if (rc > 0) {
> +	if (rc >= 0) {
>  		printf("[FAIL] (unexpected success from execveat(2))\n");
>  		return 1;
>  	}
> 


-- 
Shuah Khan
Sr. Linux Kernel Developer
Open Source Innovation Group
Samsung Research America (Silicon Valley)
shuahkh@xxxxxxxxxxxxxxx | (970) 217-8978
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/