Re: [PATCH 01/15] perf build: Disable default check for libbabeltrace

[Jiri Olsa]

On Fri, Mar 13, 2015 at 12:36:21PM -0300, Arnaldo Carvalho de Melo wrote:

SNIP

> 
> Auto-detecting system features:
> ...                         dwarf: [ on  ]
> ...                         glibc: [ on  ]
> ...                          gtk2: [ on  ]
> ...                      libaudit: [ on  ]
> ...                        libbfd: [ on  ]
> ...                        libelf: [ on  ]
> ...                       libnuma: [ on  ]
> ...                       libperl: [ on  ]
> ...                     libpython: [ on  ]
> ...                      libslang: [ on  ]
> ...                     libunwind: [ OFF ]
> ...            libdw-dwarf-unwind: [ on  ]
> ...                          zlib: [ on  ]
> ...     DWARF post unwind library: libdw
> 
>   GEN      common-cmds.h
> 
> It continues trying to find babeltrace, does not find it, emits the warning and
> just doesn't show the OFF message :-\
> 
> Can you explain _why_ this is needed?  I.e. is it to speed up feature checking?
> In what way, etc. For casual readers the intent of this patch may be difficult
> to grasp, no?
> 
> What am I missing?

this patch removes babeltrace from:
  - detected features display  -> so user's not curious where to get the latest babeltrace version ;-)
  - test-all optimization      -> so we could use features build speed up, missing babeltrace was stoping this

but we still check for babeltrace (out of the default list code)
in order to enable the ctf convert code if it's in the system

I admit the extra warning about missing babeltrace support
might be confusing, I can remove it.. ;-)

I think we could add new class of features that are enabled
just on demand and not checked by default at all, like:
  'make BABELTRACE=1' or via .config,
but we need to add support for that first

jirka
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/