Re: [PATCH] mm/slub: fix lockups on PREEMPT && !SMP kernels

[Christoph Lameter]

On Fri, 13 Mar 2015, Mark Rutland wrote:

>  	 */
> -	do {
> -		tid = this_cpu_read(s->cpu_slab->tid);
> -		c = raw_cpu_ptr(s->cpu_slab);
> -	} while (IS_ENABLED(CONFIG_PREEMPT) && unlikely(tid != c->tid));
> +	c = raw_cpu_ptr(s->cpu_slab);
> +	tid = READ_ONCE(c->tid);
>

Ok that works for the !SMP case. What about SMP and PREEMPT now?

And yes code like this was deemed safe for years and the race condition is
very subtle and difficult to trigger (also given that PREEMPT is rarely
used these days).

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/