Re: [PATCH] vxlan: fix wrong usage of VXLAN_VID_MASK

From: David Miller
Date: Fri Mar 13 2015 - 13:08:40 EST


From: Alexey Kodanev <alexey.kodanev@xxxxxxxxxx>
Date: Fri, 13 Mar 2015 19:13:53 +0300

> commit dfd8645ea1bd9127 wrongly assumes that VXLAN_VDI_MASK includes
> eight lower order reserved bits of VNI field that are using for remote
> checksum offload.
>
> Right now, when VNI number greater then 0xffff, vxlan_udp_encap_recv()
> will always return with 'bad_flag' error, reducing the usable vni range
> from 0..16777215 to 0..65535. Also, it doesn't really check whether RCO
> bits processed or not.
>
> Fix it by adding new VNI mask which has all 32 bits of VNI field:
> 24 bits for id and 8 bits for other usage.
>
> Signed-off-by: Alexey Kodanev <alexey.kodanev@xxxxxxxxxx>

Looks good, applied, thanks!
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/