Re: [PATCH v3] mmc: OCTEON: Add host driver for OCTEON MMC controller

[Aaro Koskinen]

Hi,

On Thu, Mar 05, 2015 at 05:50:31PM +0300, Aleksey Makarov wrote:
> The OCTEON MMC controller is currently found on cn61XX and cnf71XX
> devices.  Device parameters are configured from device tree data.
> 
> eMMC, MMC and SD devices are supported.
> 
> Signed-off-by: David Daney <david.daney@xxxxxxxxxx>
> Signed-off-by: Leonid Rosenboim <lrosenboim@xxxxxxxxxxxxxxxxxx>
> Signed-off-by: Aaron Williams <aaron.williams@xxxxxxxxxx>
> Signed-off-by: Chandrakala Chavva <cchavva@xxxxxxxxxxxxxxxxxx>
> Signed-off-by: Peter Swain <pswain@xxxxxxxxxx>
> [aleksey.makarov@xxxxxxxxxx: preparation for submission]
> Signed-off-by: Aleksey Makarov <aleksey.makarov@xxxxxxxxxx>

Seems to work fine on EdgeRouter Pro (cn61xx).

Tested-by: Aaro Koskinen <aaro.koskinen@xxxxxx>

However, there is a sparse warning that probably needs to be fixed:

	octeon_mmc.c:1141:29: error: incompatible types for operation (>=)
	octeon_mmc.c:1141:29:    left side has type struct gpio_desc *pwr_gpiod
	octeon_mmc.c:1141:29:    right side has type int

A.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/