Re: [PATCH v4] x86, kaslr: Access the correct kaslr_enabled variable

[Yinghai Lu]

On Sun, Mar 15, 2015 at 8:28 PM, Baoquan He <bhe@xxxxxxxxxx> wrote:
> On 03/15/15 at 12:49am, Yinghai Lu wrote:
> It's good to check the ret value as Boris suggested. However it could
> fail since early_memremap self fail, e.g slot not found. In this case
> making kaslr_enabled true may not be good.
>
> As Minfei talked with you kaslr_setup_data is a global variable inside
> kernel code, it has been ident mapped. Just derefencing the physical
> address which is virtual address too and getting the real stored value
> may be safer. And also parse_kaslr_setup is a function specified to
> handle kaslr, it doesn't make me uncomfortable to implement with a
> specific knowledge which here means the setup_data is a global varialbe
> in kernel code and no need to do early_memremap since mapping has been
> built .

I should not put that checking in. even parse_setup_data does not check
early_memmap return.

Thanks

Yinghai
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/