Re: [PATCH] [PATCH v3] mtd:spi-nor: Add Altera Quad SPI Driver

[Viet Nga Dao]

On Mon, Mar 16, 2015 at 4:35 PM, RafaÅ MiÅecki <zajec5@xxxxxxxxx> wrote:
> On 16 March 2015 at 09:16,  <vndao@xxxxxxxxxx> wrote:
>> +static struct flash_device flash_devices[] = {
>> +       FLASH_ID("epcq16-nonjedec",  2, 0x15),
>> +       FLASH_ID("epcq32-nonjedec",  2, 0x16),
>> +       FLASH_ID("epcq64-nonjedec",  2, 0x17),
>> +       FLASH_ID("epcq128-nonjedec", 2, 0x18),
>> +       FLASH_ID("epcq256-nonjedec", 2, 0x19),
>> +       FLASH_ID("epcq512-nonjedec", 2, 0x20),
>
> You could probably use EPCQ_OPCODE_ID
>
>
>> +
>> +       FLASH_ID("epcs16-nonjedec",  1, 0x14),
>> +       FLASH_ID("epcs64-nonjedec",  1, 0x16),
>> +       FLASH_ID("epcs128-nonjedec", 1, 0x18),
>
> And EPCS_OPCODE_ID here.
>
Noted
>
>> diff --git a/drivers/mtd/spi-nor/spi-nor.c b/drivers/mtd/spi-nor/spi-nor.c
>> index 43bb552..ad0c274 100644
>> --- a/drivers/mtd/spi-nor/spi-nor.c
>> +++ b/drivers/mtd/spi-nor/spi-nor.c
>> @@ -683,6 +683,17 @@ static const struct spi_device_id spi_nor_ids[] = {
>>         { "cat25c09", CAT25_INFO( 128, 8, 32, 2, SPI_NOR_NO_ERASE | SPI_NOR_NO_FR) },
>>         { "cat25c17", CAT25_INFO( 256, 8, 32, 2, SPI_NOR_NO_ERASE | SPI_NOR_NO_FR) },
>>         { "cat25128", CAT25_INFO(2048, 8, 64, 2, SPI_NOR_NO_ERASE | SPI_NOR_NO_FR) },
>> +
>> +       /* Altera EPCQ/EPCS Flashes */
>> +       { "epcq16-nonjedec",  INFO(0, 0, 0x10000, 32,   0) },
>> +       { "epcq32-nonjedec",  INFO(0, 0, 0x10000, 64,   0) },
>> +       { "epcq64-nonjedec",  INFO(0, 0, 0x10000, 128,  0) },
>> +       { "epcq128-nonjedec", INFO(0, 0, 0x10000, 256,  0) },
>> +       { "epcq256-nonjedec", INFO(0, 0, 0x10000, 512,  0) },
>> +       { "epcq512-nonjedec", INFO(0, 0, 0x10000, 1024, 0) },
>> +       { "epcs16-nonjedec",  INFO(0, 0, 0x10000, 32,   0) },
>> +       { "epcs64-nonjedec",  INFO(0, 0, 0x10000, 128,  0) },
>> +       { "epcs128-nonjedec", INFO(0, 0, 0x40000, 256,  0) },
>>         { },
>>  };
>
> But mostly, I just wanted to say I like your integration with spi-nor.
> Nice work :)
>
> --
> RafaÅ

Thank you. This is all thanks to you and Brian for helpful comments. I
learned a lot :)
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/