Re: reiserfs: inconsistent format in __RASSERT
From: Jeff Mahoney
Date: Mon Mar 16 2015 - 09:05:17 EST
-----BEGIN PGP SIGNED MESSAGE-----
On 3/16/15 8:55 AM, Nicolas Iooss wrote:
> When adding a __printf attribute to reiserfs_panic, gcc reported
> an inconsistent format for __RASSERT. This macro is currently
> defined in fs/reiserfs/reiserfs.h as:
> reiserfs_panic(NULL, "assertion failure", "(" #cond ") at " \
> __FILE__ ":%i:%s: " format "\n", \
> in_interrupt() ? -1 : task_pid_nr(current), \ __LINE__,
> __func__ , ##args);
> In the format string, the first parameter is a line number, but in
> the arguments there is a PID before. Before c3a9c2109f84
> ("reiserfs: rework reiserfs_panic") , the format string began
> with "reiserfs[%i]" , which explains the PID in the arguments.
> I see three possibilities:
> * I missed something in my analysis and in fact the PID argument
> is processed by reiserfs_panic (don't know where), or * the PID
> argument is not used and should be removed, or
This, please. reiserfs_panic calls BUG(), which will contain the PID.
> * the PID is useful and "[%i]" should be added somewhere in the
> format string.
> Which one would you prefer?
> Also, I found this when building the kernel with "allmodconfig" on
> x86_64. With "defconfig" gcc does not report this error, but I
> guess it is because without CONFIG_REISERFS_CHECK, __RASSERT is
> never used.
Yeah. If reiserfs was more actively maintained, what is currently
protected by CONFIG_REISERFS_CHECK would be handled a bit better.
There are ton of fsfuzzer bugs that would be caught by it and should
be handled using reiserfs_error. Unfortunately, it also enables some
heavy checks that make the file system very slow.
Thanks for looking into this. It looks like it's been broken for a
while. I suppose the only saving grace is that it would crash in a
path that crashes on purpose a few lines later.
-----BEGIN PGP SIGNATURE-----
Version: GnuPG/MacGPG2 v2.0.19 (Darwin)
-----END PGP SIGNATURE-----
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/