[PATCH] x86,boot: standardize strcmp()

From: Arjun Sreedharan
Date: Mon Mar 16 2015 - 11:38:20 EST


strcmp() is always expected to return 0 when args are
same, <0 when arg1 is lesser and >0 otherwise.
Previously strcmp("a","b") returned 1. Now it gives -1.

Signed-off-by: Arjun Sreedharan <arjun024@xxxxxxxxx>
---
arch/x86/boot/string.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/x86/boot/string.c b/arch/x86/boot/string.c
index 493f3fd..318b846 100644
--- a/arch/x86/boot/string.c
+++ b/arch/x86/boot/string.c
@@ -30,7 +30,7 @@ int strcmp(const char *str1, const char *str2)
int delta = 0;

while (*s1 || *s2) {
- delta = *s2 - *s1;
+ delta = *s1 - *s2;
if (delta)
return delta;
s1++;
--
1.8.1.msysgit.1

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/