Re: [PATCH] kernfs: handle poll correctly on 'direct_read' files.

From: Tejun Heo
Date: Mon Mar 16 2015 - 12:30:31 EST

On Mon, Mar 16, 2015 at 10:44:52AM +1100, NeilBrown wrote:
> Kernfs supports two styles of read: direct_read and seqfile_read.
> The latter supports 'poll' correctly thanks to the update of
> '->event' in kernfs_seq_show.
> The former does not as '->event' is never updated on a read.
> So add an appropriate update in kernfs_file_direct_read().
> This was noticed because some 'md' sysfs attributes were
> recently changed to use direct reads.
> Reported-by: Prakash Punnoor <prakash@xxxxxxxxxx>
> Reported-by: Torsten Kaiser <just.for.lkml@xxxxxxxxxxxxxx>
> Fixes: 750f199ee8b578062341e6ddfe36c59ac8ff2dcb

This fixes tag is kinda weird without further explanation.

> Signed-off-by: NeilBrown <neilb@xxxxxxx>

Acked-by: Tejun Heo <tj@xxxxxxxxxx>


To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at