Re: [PATCH v2 15/16] staging: rtl8723au: Correct a typo in a trace log line

[Jes Sorensen]

"M. Vefa Bicakci" <m.v.b@xxxxxxxxxx> writes:
> Correct a typo in rtl8723au's rtw_security.c which was most likely
> caused by a copy and paste mistake. Prior to this commit, the TKIP
> decryption function referred to WEP in its trace log output.
>
> Signed-off-by: M. Vefa Bicakci <m.v.b@xxxxxxxxxx>
> ---
>  drivers/staging/rtl8723au/core/rtw_security.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/rtl8723au/core/rtw_security.c b/drivers/staging/rtl8723au/core/rtw_security.c
> index eb3544866a..e8d3ce53bb 100644
> --- a/drivers/staging/rtl8723au/core/rtw_security.c
> +++ b/drivers/staging/rtl8723au/core/rtw_security.c
> @@ -757,7 +757,7 @@ int rtw_tkip_decrypt23a(struct rtw_adapter *padapter,
>  
>  	if (actual_crc != expected_crc) {
>  		RT_TRACE(_module_rtl871x_security_c_, _drv_err_,
> -			 ("rtw_wep_decrypt23a:icv CRC mismatch: "
> +			 ("rtw_tkip_decrypt23a:icv CRC mismatch: "

If you made this ("%s:icv ....", __func__, ....

you wouldn't have to worry about matching the function name to the debug
text, in case the function later got renamed.

Cheers,
Jes

>  			  "actual: %08x, expected: %08x\n",
>  			  actual_crc, expected_crc));
>  		res = _FAIL;
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/