Re: [PATCH 09/13] VFS/namei: enable RCU-walk when following symlinks.

From: Al Viro
Date: Mon Mar 16 2015 - 18:44:35 EST


On Mon, Mar 16, 2015 at 03:43:20PM +1100, NeilBrown wrote:
> if (should_follow_link(path->dentry, follow)) {
> - if (nd->flags & LOOKUP_RCU) {
> - if (unlikely(unlazy_walk(nd, path->dentry))) {
> - err = -ECHILD;
> - goto out_err;
> - }
> - }
> BUG_ON(inode != path->dentry->d_inode);

... and now this BUG_ON() can bloody well be triggered.
> if (should_follow_link(path->dentry, !symlink_ok)) {
> - if (nd->flags & LOOKUP_RCU) {
> - if (unlikely(unlazy_walk(nd, path->dentry))) {
> - error = -ECHILD;
> - goto out;
> - }
> - }
> BUG_ON(inode != path->dentry->d_inode);

So can this.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/