Re: Possible no longer required cast in the function,usbhs_parse_dt in common.c
From: gregkh@xxxxxxxxxxxxxxxxxxx
Date: Tue Mar 17 2015 - 03:51:38 EST
On Tue, Mar 17, 2015 at 03:37:42AM +0000, Peter Chen wrote:
>
> >
> > Greetings All,
> > I have been getting the below build warnings:
> > drivers/usb/renesas_usbhs/common.c: In function âusbhs_parse_dtâ:
> > drivers/usb/renesas_usbhs/common.c:482:25: warning: cast from pointer to
> > integer of different size [-Wpointer-to-int-cast]
> > dparam->type = of_id ? (u32)of_id->data : 0;
> > After looking into the function I am curious if the hardware is only 32 bit as if
> > the supported hardware for this driver is then this cast is no longer required
> > and I can send in a patch removing it. Furthermore, sorry for the simple
> > question but I don't have access to the device specs for supported hardware
> > so I though it would be better to ask before I send in patch fixing this issue.
> > Thanks,
> > Nick
>
> Patch is welcome, there will be comment if it is not suitable.
Sorry, but no, a patch is not welcome from Nick. You all will note that
Nick is banned from vger.kernel.org and I would recommend that everyone
else on the cc: here also add him to their kill-files. It will make
your life much easier.
greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/