Re: [RFC][PATCH 2/9] module: Sanitize RCU usage and locking

[Peter Zijlstra]

On Mon, Mar 02, 2015 at 11:37:06AM -0800, Paul E. McKenney wrote:
> > -	/* Wait for RCU synchronizing before releasing mod->list and buglist. */
> > -	synchronize_rcu();
> > +	/* Wait for RCU-sched synchronizing before releasing mod->list and buglist. */
> > +	synchronize_sched();
> >  	mutex_unlock(&module_mutex);
> 
> There might be some reasons why the synchronize_sched() needs to be
> within the module_mutex critical section, but safe freeing of memory
> and the integrity of the list are not two of them.  Doesn't hurt anything
> unless someone is being very active with their modules, of course.

Yeah, I could not find anything that relies on that; but I'm not too
familiar with all the module stuff -- although a lot more now that I was
a few weeks back ;-)
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/