Re: [PATCH 2/2] add newhaven lcd tty driver on i2c

[Greg Kroah-Hartman]

On Tue, Mar 17, 2015 at 03:36:47PM -0500, Alan Tull wrote:
> Supports the Newhaven NHDâ0216K3ZâNSWâBBW 2x16 LCD module as i2c slave.
> Devices will show up as /dev/ttyLCD0, etc.
> 
>  * Backspace is supported to the beginning of the current line.
>     * i.e. printf '\b' > /dev/ttyLCD0
> 
>  * ESC [ 2 J
>     * erase whole display and reset cursor to home.
>     * i.e. printf '\e[2J' > /dev/ttyLCD0
> 
>  * ESC [ 2 K
>     * erase current line and set cursor to beginning of line.
>     * i.e. printf '\e[2K' > /dev/ttyLCD0
> 
>  * CR and LF are supported.
> 
>  * Vertical scroll when cursor is on bottom line and receive end of line.
> 
> Default brightness can be set from the device tree/plat data.
> 
> Brightness can be set from a sysfs file, for example:
>  * echo 6 > /sys/devices/soc.0/ffc04000.i2c/i2c-0/0-0028/brightness
> 
> Signed-off-by: Alan Tull <atull@xxxxxxxxxxxxxxxxxxxxx>

This should use the new fb_tft api instead of trying to look like a tty
device.  That framework is merged in the staging-next branch of the
staging.git kernel tree and will show up in 4.1-rc1.  Please port this
driver to that api and submit a patch for me to take for the staging
tree so that we don't have one-off devices like this.

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/