Re: [PATCH v3 1/4] ARM: EXYNOS: fix CPU1 hotplug for AFTR mode on Exynos3250

[Krzysztof Kozlowski]

On Åro, 2015-03-18 at 14:23 +0100, Bartlomiej Zolnierkiewicz wrote:
> Hi,
> 
> On Wednesday, March 18, 2015 02:10:31 PM Krzysztof Kozlowski wrote:
> > 2015-03-18 13:51 GMT+01:00 Bartlomiej Zolnierkiewicz <b.zolnierkie@xxxxxxxxxxx>:
> > >
> > > +       while (!pmu_raw_readl(S5P_PMU_SPARE2))
> > > +               udelay(10);
> > > +       udelay(10);
> > 
> > We really need to start documenting this. Please add short description
> > why this SPARE2 check is here and who uses it. Without documenting
> > this behavior future generations won't be able to debug this stuff.
> > Imagine replacing sboot with uboot by someone...
> 
> I've already planned to do this for this code and for coupled cpuidle
> use of SPARE2 as well.  However I would really prefer to do it in
> an incremental patch if there are no other issues with this patchset.

OK, please do so in incremental patch. Usage of various memory regions
of sysram also should be documented. In patch 2 you add usage of 0x28 +
4*cpu. The various sysrams regions are spread over different files...

Best regards,
Krzysztof

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/