Re: [PATCH v2] Staging: dgnc: release the lock before testing for nullity

From: Quentin Lambert
Date: Wed Mar 18 2015 - 09:43:11 EST




On 18/03/2015 14:36, Dan Carpenter wrote:
This changelog still doesn't make sense so I took a look at the code.

tty_ldisc_deref() is an unlock function. So this is a lock ordering
bug. What makes you think the original ordering was correct? Who
reported this bug? What are the effects of this bug?
I was the one who introduced the ordering change in the first place.
I am just trying to fix it because although nobody complained I am not
sure of the impact and restoring the previous control flow seems to be the
right thing to do.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/