Re: [PATCH] staging: lustre: namei.c: coding style: fix 80 characters limit

[gregkh@xxxxxxxxxxxxxxxxxxx]

On Wed, Mar 18, 2015 at 07:53:35PM +0000, Dilger, Andreas wrote:
> On 2015/03/18, 1:07 PM, "Maxime Lorrillere" <maxime.lorrillere@xxxxxxx>
> wrote:
> 
> >From: Laure Millet <laure.millet@xxxxxxx>
> >
> >This patch fixes lines over 80 characters
> 
> I think the newer rule is that strings shouldn't be split across lines.
> That makes
> the first hunk invalid, though the second one is OK.

No, that first hunk is just fine, that horrid DFID macro allows it to
now be split :)

To fix this correctly, you need to move to using the "real" in-kernel
pr_err() functions, not custom macros.  When that happens, checkpatch.pl
will stop complaining.

I'll take this one as-is.

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/