Re: [HPDD-discuss] [PATCH] Staging: lustre: file.c: fix coding style

From: Julia Lawall
Date: Wed Mar 18 2015 - 18:46:16 EST


On Wed, 18 Mar 2015, Patrick Farrell wrote:

> Uck, my reply made the formatting even worse. I'm trying to say it should
> look like this:
> + rc = ll_intent_file_open(file->f_path.dentry,
> + NULL, 0, it);
> Not like this:
> + rc = ll_intent_file_open(file->f_path.dentry,
> + NULL, 0, it);

Both look wrong to me. Are your tabs equivalent to 8 spaces?

julia

>
> On 03/18/2015 02:31 PM, Patrick Farrell wrote:
> > Perhaps this is just a formatting error in my email client, but shouldn't
> > NULL be one more space over to line up with the '(' above?
> >
> > On 03/18/2015 02:08 PM, py@xxxxxxxxxxxxxxxxxxxxx wrote:
> > > + rc = ll_intent_file_open(file->f_path.dentry,
> > > + NULL, 0, it);
> >
> > _______________________________________________
> > HPDD-discuss mailing list
> > HPDD-discuss@xxxxxxxxxxxx
> > https://lists.01.org/mailman/listinfo/hpdd-discuss
>
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/