Re: [PATCH 1/4] ptp/chardev:Introduce another option to get/set time in ptp_clock_info structure

From: Richard Cochran
Date: Thu Mar 19 2015 - 03:48:40 EST

On Thu, Mar 19, 2015 at 01:45:06PM +0800, Baolin Wang wrote:

> diff --git a/include/linux/ptp_clock_kernel.h b/include/linux/ptp_clock_kernel.h
> index 0d8ff3f..86decc2 100644
> --- a/include/linux/ptp_clock_kernel.h
> +++ b/include/linux/ptp_clock_kernel.h
> @@ -105,7 +105,9 @@ struct ptp_clock_info {
> int (*adjfreq)(struct ptp_clock_info *ptp, s32 delta);
> int (*adjtime)(struct ptp_clock_info *ptp, s64 delta);
> int (*gettime)(struct ptp_clock_info *ptp, struct timespec *ts);
> + int (*getktime)(struct ptp_clock_info *ptp, ktime_t *kt);
> int (*settime)(struct ptp_clock_info *ptp, const struct timespec *ts);
> + int (*setktime)(struct ptp_clock_info *ptp, ktime_t kt);

You have added alternate methods that do exactly the same thing as
gettime/settime. Then, you convert just two drivers over to the new

I don't want to have this job half done, with some driver being
forgotten along the way. Please, just change the signatures of
gettime/settime and convert *all* of the drivers. After all, there
are not that many drivers to convert.


> int (*enable)(struct ptp_clock_info *ptp,
> struct ptp_clock_request *request, int on);
> int (*verify)(struct ptp_clock_info *ptp, unsigned int pin,
> --
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at