Re: [PATCH v2] checkpatch: support more uppercase $logFunctions

From: Tom Van Braeckel
Date: Thu Mar 19 2015 - 05:58:14 EST


>> unfixable checkpatch warnings (an example: drivers/bluetooth/btusb.c)
>
> I think BT_DBG is a poor macro as it's just
>
> #define BT_DBG(fmt, ...) pr_debug(fmt "\n", ##__VA_ARGS__)
>
> and I'd rather see a treewide sed for that to pr_debug

Indeed, I also think that BT_DBG() is a poor macro and that it should
be fixed tree-wide. I might even do it myself, in a separate patch.

The reason for DBG being in the current patch is to match other *_DBG()
log functions that make more sense, such as NS_DBG().

As for the btusb.c example case, this patch allows us to fix the
"quoted string split across lines" warning caused by the BT_INFO()
macro. The fix will be to not to split the quoted string, which will
be allowed when BT_INFO() is recognized as a log function.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/