Re: [PATCH 3/3] EDAC: amd64_edac: decide if driver can load successfully early.
From: Dmitry Torokhov
Date: Thu Mar 19 2015 - 12:58:01 EST
On Thu, Mar 19, 2015 at 12:12:41PM -0400, Tejun Heo wrote:
> On Thu, Mar 19, 2015 at 05:01:32PM +0100, Borislav Petkov wrote:
> > On Thu, Mar 19, 2015 at 11:55:53AM -0400, Tejun Heo wrote:
> > <snip needless schooling on driver core>
> >
> > > This code is standing in the way of a much more impactful generic
> > > driver layer improvement.
> >
> > So why not mark it as synchronously loading and forget about it?
>
> Isn't that obvious? Because hacks like this are likely to cause other
> problems down the road and set bad precedences.
In all fairness platform_driver_probe() does pretty much the same and
forces us to mark thus drivers with PROBE_FORCE_SYNCHRONOUS as well. And
there are quite a few of them:
dtor@dtor-ws:~/kernel/work$ grep -r "platform_driver_probe" drivers/ |
wc -l
186
What makes edac unusual is that PCI bus is hot-pluggable and thus PCI
drivers are rarely one-shot.
Thanks.
--
Dmitry
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/