Re: [UPDATED] [PATCH 3/5] arm-cci: Get rid of secure transactions for PMU driver

[Sudeep Holla]

On 19/03/15 17:32, Mark Rutland wrote:
> One more thing:
>
> > @@ -883,7 +894,11 @@ static inline const struct cci_pmu_model *get_cci_model(struct platform_device *
> >   							pdev->dev.of_node);
> >   	if (!match)
> >   		return NULL;
> > +	if (match->data)
> > +		return match->data;
> >
> > +	dev_warn(&pdev->dev, "DEPRECATED compatible property,"
> > +			 "requires secure access to CCI registers");
> >   	return probe_cci_model(pdev);
> >   }
>
> Before the probe, could we please have:
>
> 	if (!IS_ENABLED(CONFIG_ARM))
> 		return -EINVAL;
>
> On arm64 we require a model-specific string, and we shouldn't go
> touching secure-only registers.

IIUC platform_has_secure_cci_access always return false for ARM64
preventing any secure access. No ?

Regards,
Sudeep

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/