Re: [PATCH 04/16] page-flags: define PG_locked behavior on compound pages

[Hillf Danton]

> --- a/include/linux/page-flags.h
> +++ b/include/linux/page-flags.h
> @@ -269,7 +269,7 @@ static inline struct page *compound_head_fast(struct page *page)
>  	return page;
>  }
> 
> -TESTPAGEFLAG(Locked, locked, ANY)
> +__PAGEFLAG(Locked, locked, NO_TAIL)
>  PAGEFLAG(Error, error, ANY) TESTCLEARFLAG(Error, error, ANY)
>  PAGEFLAG(Referenced, referenced, ANY) TESTCLEARFLAG(Referenced, referenced, ANY)
>  	__SETPAGEFLAG(Referenced, referenced, ANY)
[...]
> @@ -490,9 +481,9 @@ extern int wait_on_page_bit_killable_timeout(struct page *page,
> 
>  static inline int wait_on_page_locked_killable(struct page *page)
>  {
> -	if (PageLocked(page))
> -		return wait_on_page_bit_killable(page, PG_locked);
> -	return 0;
> +	if (!PageLocked(page))
> +		return 0;

I am lost here: can we feed any page to NO_TAIL operation?

> +	return wait_on_page_bit_killable(compound_head(page), PG_locked);
>  }
> 

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/