Re: [PATCH v5] sched/rt: Use IPI to trigger RT task push migration instead of pulling

[Peter Zijlstra]

On Wed, Mar 18, 2015 at 02:49:46PM -0400, Steven Rostedt wrote:
> +static int find_next_push_cpu(struct rq *rq)
> +{
> +	struct rq *next_rq;
> +	int cpu;
> +
> +	while (1) {

We typically tend to write: for (;;), instead, however would a do { }
while () loop not make more sense here?

	do {
		cpu = rto_next_cpu(rq);
		if (cpu >= nr_cpu_ids)
			break;

		next_rq = cpu_rq(cpu);
	} while (next_rq->rt.highest_prio.next >= rq->rt.highest_prio.curr);

> +	return cpu;
> +}
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/